Re: [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback
From: Daniel Vetter
Date: Thu Jun 22 2017 - 04:46:30 EST
On Wed, Jun 21, 2017 at 10:38:43AM +0100, Jose Abreu wrote:
> Hi Daniel, Alexey,
> On 25-05-2017 15:19, Jose Abreu wrote:
> > Now that we have a callback to check if crtc supports a given mode
> > we can use it in arcpgu so that we restrict the number of probbed
> > modes to the ones we can actually display.
> > This is specially useful because arcpgu crtc is responsible to set
> > a clock value in the commit() stage but unfortunatelly this clock
> > does not support all the needed ranges.
> > Also, remove the atomic_check() callback as mode_valid() callback
> > will be called before.
> > Signed-off-by: Jose Abreu <joabreu@xxxxxxxxxxxx>
> > Reviewed-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
> @Daniel: I know that arcpgu is not under drm-misc but could you
> apply this into drm-misc-next? Alexey (the arcpgu maintainer)
> already gave the reviewed-by and this is also "Reviewed-by: Neil
> Armstrong <narmstrong@xxxxxxxxxxxx>". It was also tested-by: me.
> @Alexey: Is this ok for you?
> I need this because I have a pending patch for accepting clock
> variations instead of always failing when clk_round_rate() does
> not return the expected rate.
Alexey reviewed it already, and Dave acked it for merging through
drm-misc, so applied.
Software Engineer, Intel Corporation