Re: [PATCH] kbuild: deprecate cc-option-align

From: Ingo Molnar
Date: Thu Jun 22 2017 - 04:59:56 EST



* Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:

> Documentation/kbuild/makefiles.txt says the change for align options
> occurred at GCC 3.0, and Documentation/process/changes.rst says the
> minimal supported GCC version is 3.2, so it should be safe to hard-code
> -falign* options.
>
> Fix the only user arch/x86/Makefile_32.cpu and deprecate the
> cc-option-align.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> x86 maintainers,
>
> If this patch looks OK, could you give me Acked-by?

LGTM in principle, although I haven't tested it:

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo