Re: [PATCH v2] Moved module init-functions into the module.

From: Steve Kemp
Date: Thu Jun 22 2017 - 13:25:04 EST

> > The module initialization code belongs in the module.
> > The LSM infrastructure should have an absolute minimum
> > of module specific information. I would rather see the
> > "minor" modules (yama, loadpin) changed to use the module
> > registration scheme used by the "major" modules, but that
> > will require a mechanism to ensure module ordering, and
> > we don't have that yet. No, don't do this.
> Yeah, I agree: initialization order is important here and I don't want
> to depend on the Makefile for this.

I can appreciate that argument. I did consider it myself,
but decided that because the minor modules had such differing
goals, and no real functional overlap, in practice that would
mean that explicit ordering wasn't a strong requirement.

If/when a better registration scheme becomes available then
we'll all switch to using it, and that would be great.

Thanks for the feedback. I'll not tweak any further.