Re: [PATCH] dt-bindings: mtd: elm: Correct compatible string requirement

From: Boris Brezillon
Date: Thu Jun 22 2017 - 15:14:21 EST


On Wed, 21 Jun 2017 08:22:06 -0400
Tom Rini <trini@xxxxxxxxxxxx> wrote:

> The binding says that the compatible string must be "ti,am33xx-elm"
> but the code checks only for, and all functioning users set, this as
> "ti,am3352-elm" so correct the binding.
>
> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> Cc: Brian Norris <computersforpeace@xxxxxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Cc: Marek Vasut <marek.vasut@xxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Cyrille Pitchen <cyrille.pitchen@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Signed-off-by: Tom Rini <trini@xxxxxxxxxxxx>

Applied.

Thanks,

Boris

> ---
> I have submitted a separate patch that correct the dm816x.dtsi to set
> the compatible string there for the elm from ti,816-elm to ti,am3352-elm
> and tested it on the hardware, where it works. It is quite likely that
> dm814x.dtsi can be trivially corrected as it came after dm816x and
> before am335x but as I cannot test the hardware, I did not update that.
> ---
> Documentation/devicetree/bindings/mtd/elm.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
> index 8c1528c421d4..59ddc61c1076 100644
> --- a/Documentation/devicetree/bindings/mtd/elm.txt
> +++ b/Documentation/devicetree/bindings/mtd/elm.txt
> @@ -1,7 +1,7 @@
> Error location module
>
> Required properties:
> -- compatible: Must be "ti,am33xx-elm"
> +- compatible: Must be "ti,am3352-elm"
> - reg: physical base address and size of the registers map.
> - interrupts: Interrupt number for the elm.
>