Re: [PATCH] kconfig: fix sparse warnings in nconfig

From: Masahiro Yamada
Date: Thu Jun 22 2017 - 23:22:07 EST


2017-05-23 10:44 GMT+09:00 Randy Dunlap <rdunlap@xxxxxxxxxxxxx>:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix sparse warnings in scripts/kconfig/nconf* ('make nconfig'):
>
> ../scripts/kconfig/nconf.c:1071:32: warning: Using plain integer as NULL pointer
> ../scripts/kconfig/nconf.c:1238:30: warning: Using plain integer as NULL pointer
> ../scripts/kconfig/nconf.c:511:51: warning: Using plain integer as NULL pointer
> ../scripts/kconfig/nconf.c:1460:6: warning: symbol 'setup_windows' was not declared. Should it be static?
> ../scripts/kconfig/nconf.c:274:12: warning: symbol 'current_instructions' was not declared. Should it be static?
> ../scripts/kconfig/nconf.c:308:22: warning: symbol 'function_keys' was not declared. Should it be static?
> ../scripts/kconfig/nconf.gui.c:132:17: warning: non-ANSI function declaration of function 'set_colors'
> ../scripts/kconfig/nconf.gui.c:195:24: warning: Using plain integer as NULL pointer
>
> nconf.gui.o before/after files are the same.
> nconf.o before/after files are the same until the 'static' function
> declarations are added.
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Applied to linux-kbuild/fixes. Thanks!

--
Best Regards
Masahiro Yamada