Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops

From: Bjorn Andersson
Date: Sun Jun 25 2017 - 17:44:00 EST


On Fri 02 Jun 04:36 PDT 2017, Henri Roosen wrote:

> Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
> first assignment.
>
> Signed-off-by: Henri Roosen <henri.roosen@xxxxxxxxxxxxx>

Applied, thanks

> ---
> drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 3c582f2..35b8379 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
> /* Link the channel to our vrp */
> vch->vrp = vrp;
>
> - /* Assign callbacks for rpmsg_channel */
> - vch->rpdev.ops = &virtio_rpmsg_ops;
> -
> /* Assign public information to the rpmsg_device */
> rpdev = &vch->rpdev;
> rpdev->src = chinfo->src;
> --
> 2.1.4
>