Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and del_usage_link functions

From: Jessica Yu
Date: Mon Jun 26 2017 - 09:37:31 EST


+++ Corentin Labbe [20/06/17 08:45 +0200]:
On Mon, Jun 19, 2017 at 06:26:23PM +0200, Jessica Yu wrote:
+++ Corentin Labbe [06/06/17 14:17 +0200]:
>This patch just swap del_usage_link() before add_usage_link().
>
>Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>

Could you combine this with the 2nd patch? By itself this patch
doesn't tell us much. Additionally, could you explain in the changelog
(of the 2nd patch) why they needed to be swapped (i.e., so
del_usage_links() can be called from add_usage_links()).

Thanks!

Jessica


I think that its against the rule of atomic/simple patch.
Perhaps, the first patch miss some "why I do it"

Anyway I will send a new version as you requested

Hi Corentin,

I've folded the first patch with the second and applied them to
modules-next, no need to resend the patchset :)

Thanks!

Jessica