Re: [PATCH] fsl/fman: add dependency on HAS_DMA

From: Geert Uytterhoeven
Date: Mon Jun 26 2017 - 12:17:36 EST


On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@xxxxxxx> wrote:
>> A previous commit inserted a dependency on DMA API that requires
>> HAS_DMA to be added in Kconfig.
>
> It would be nice to specify the commit that caused this.

That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").

However, none of the fman code uses any DMA API calls, so IMHO
the set_dma_ops() should be done somewhere else.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds