Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

From: Madhani, Himanshu
Date: Tue Jun 27 2017 - 21:44:57 EST


Hi Martin,

On 6/27/17, 6:32 PM, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> wrote:


> In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
> qpair->qp_lock but do access members of the qpair before having the lock.
> Re-order the locking sequence to have all read and write access to qpair
> members under the qpair->qp_lock.

Cavium folks, please review!

I am testing it internally, will update by tomorrow.

--
Martin K. Petersen Oracle Linux Engineering

Thanks,
Himanshu