Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

From: Andy Shevchenko
Date: Wed Jun 28 2017 - 05:23:12 EST


On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham
<chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:
> Switch to using the devm_ APIs and remove the now unnecessary error
> handling and most of the device removal code.


> if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
> - ret = -ENODEV;
> - goto e_adapt;
> + return -ENODEV;

This is still shadows the actual error code.

--
With Best Regards,
Andy Shevchenko