Re: [PATCH] spmi: Include OF based modalias in device uevent

From: Bjorn Andersson
Date: Thu Jun 29 2017 - 17:37:18 EST


On Thu 29 Jun 14:04 PDT 2017, Stephen Boyd wrote:

> On 06/28, Bjorn Andersson wrote:
> > Include the OF-based modalias in the uevent sent when registering SPMI
> > devices, so that user space has a chance to autoload the kernel module
> > for the device.
> >
> > Reported-by: Rob Clark <robdclark@xxxxxxxxx>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>
> I suppose we can delete the MODALIAS in the qcom-spmi-pmic file
> too? That doesn't look like it could ever work
>

Right, it has never worked. Potentially we would like some SPMI based
modalias thing, but I'm not sure we have enough information about the
found device to create a meaningful alias.

Regards,
Bjorn