Re: [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs
From: Chao Yu
Date: Sat Jul 01 2017 - 12:15:24 EST
On 2017/7/1 15:48, Jaegeuk Kim wrote:
> On 06/29, Chao Yu wrote:
>> From: Chao Yu <yuchao0@xxxxxxxxxx>
>> Don't clear old mount option before parse new option during ->remount_fs
>> like other generic filesystems>
> So, what happened on your original patch?
> commit 26666c8a4366debae30ae37d0688b2bec92d196a
> f2fs: fix to clean previous mount option when remount_fs
> I think we need to rever the original patch tho.
I just removed this for passing some quota testcases in xfstests suit,
and after that, I didn't get further failures in other testcases.
Let me check this again.
>> Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
>> fs/f2fs/super.c | 1 -
>> 1 file changed, 1 deletion(-)
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index f27c141cd8aa..af472f7968d0 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -846,7 +846,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>> clear_sbi_flag(sbi, SBI_NEED_SB_WRITE);
>> - sbi->mount_opt.opt = 0;
>> /* parse mount options */