Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning

From: Martin K. Petersen
Date: Sat Jul 01 2017 - 17:15:58 EST


> When NVMe support is disabled, we get a couple of harmless warnings:
> drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: 'qla_nvme_unregister_remote_port' defined but not used [-Werror=unused-function]
> drivers/scsi/qla2xxx/qla_nvme.c:634:13: error: 'qla_nvme_abort_all' defined but not used [-Werror=unused-function]
> drivers/scsi/qla2xxx/qla_nvme.c:604:12: error: 'qla_nvme_wait_on_rport_del' defined but not used [-Werror=unused-function]
> This replaces the preprocessor checks in the code with equivalent
> compiler conditionals, which lets gcc drop the unused functions
> without warning, and is nicer to read.

Applied to 4.13/scsi-queue.

Martin K. Petersen Oracle Linux Engineering