Re: [PATCH] gpiolib: skip unwanted events, don't convert them to opposite edge

From: Andy Shevchenko
Date: Mon Jul 03 2017 - 07:07:25 EST

On Mon, Jul 3, 2017 at 12:12 PM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> The previous fix for filtering out of unwatched events was not entirely
> correct. Instead of skipping the events we don't want, they are now
> interpreted as events with opposing edge.
> In order to fix it: always read the GPIO line value on interrupt and
> only emit the event if it corresponds with the event type we requested.

> struct lineevent_state *le = p;
> struct gpioevent_data ge;
> - int ret;
> + int ret, level;

I prefer
int level;
int ret;

Though it's matter of taste (I don't remember which one Linus' preferable).

With Best Regards,
Andy Shevchenko