Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory initially

From: Jan Beulich
Date: Mon Jul 03 2017 - 12:11:24 EST


>>> On 03.07.17 at 17:40, <jgross@xxxxxxxx> wrote:
> --- a/drivers/xen/xen-balloon.c
> +++ b/drivers/xen/xen-balloon.c
> @@ -59,6 +59,8 @@ static void watch_target(struct xenbus_watch *watch,
> {
> unsigned long long new_target;
> int err;
> + static bool watch_fired;
> + static unsigned long target_diff;

It would seem to me that the types of target_diff and new_target
should match in width, but differ in signedness.

Jan