Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h
From: Masahiro Yamada
Date: Tue Jul 04 2017 - 06:39:44 EST
2017-07-04 19:06 GMT+09:00 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:
> On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote:
>> Some of include directives in include/linux/gpio/driver.h are
>> unneeded because the header does not need to know the content of
>> struct device, irq_chip, etc. Just declare they are structures.
>> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
>> turned out to be necessary for irq_flow_handler_t and spinlock_t,
>> Each driver should include what it needs without relying on what is
>> implicitly included from <linux/gpio/driver.h>. This will cut down
>> unnecessary header parsing.
> If Linus is okay with the following proposal I would rather go with it,
> i.e. logical split the series to
> 1. Fix IRQ related headers inclusion
> 2. Fix pinconf-generic.h inclusion
> 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)
4. Fix (platform_)device inclusion
But, I do not see much sense to touch headers multiple times.