Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.
From: Maxime Ripard
Date: Tue Jul 04 2017 - 16:18:09 EST
On Tue, Jul 04, 2017 at 03:25:45PM +0800, Yong wrote:
> On Mon, 3 Jul 2017 13:25:21 +0200
> Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> > Hi,
> > On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote:
> > > > > + select VIDEOBUF2_DMA_CONTIG
> > > > > + select REGMAP_MMIO
> > > > > + ---help---
> > > > > + Support for the Allwinner Camera Sensor Interface Controller.
> > > >
> > > > This controller is the same for all Allwinner SoC models?
> > >
> > > No.
> > > I will change the Kconfig and Makefile.
> > This is basically a design that has been introduced in the A31 (sun6i
> > family). I guess we should just call the driver and Kconfig symbols
> > sun6i_csi (even though we don't support it yet). It also used on the
> > A23, A33, A80, A83T, H3, and probably the H5 and A64.
> Thanks for the advice. That's good.
> My purpose is to make the code reusable. People working on other
> Allwinner SoC could easily make their CSI working by just filling the
> SoC specific code. But I'm not familiar with other Allwinner SoCs
> except V3s. I hope to get more advice.
Right, of course we don't expect you to do all that work, and we
should definitely focus on the V3s that you have for now. My comment
was only about the driver name and Kconfig option.
For the rest of the code, see the other comments :)
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
Description: PGP signature