[PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

From: Gustavo A. R. Silva
Date: Tue Jul 04 2017 - 18:08:57 EST

Remove unnecessary static on local variable _type_.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;

static T x@p;
x = <+...x...+>

identifier x;
expression e;
type T;
position p != bad.p;

T x@p;
... when != x
when strict
?x = e;

In the following log you can see the difference in the code size and,
also a significant difference in bss segment. This log is the output
of the size command, before and after the code change:

text data bss dec hex filename
2966 920 128 4014 fae drivers/edac/debugfs.o

text data bss dec hex filename
2961 832 64 3857 f11 drivers/edac/debugfs.o

Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
drivers/edac/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/debugfs.c b/drivers/edac/debugfs.c
index 92dbb7e..ba0af49 100644
--- a/drivers/edac/debugfs.c
+++ b/drivers/edac/debugfs.c
@@ -8,7 +8,7 @@ static ssize_t edac_fake_inject_write(struct file *file,
struct device *dev = file->private_data;
struct mem_ctl_info *mci = to_mci(dev);
- static enum hw_event_mc_err_type type;
+ enum hw_event_mc_err_type type;
u16 errcount = mci->fake_inject_count;

if (!errcount)