Re: [PATCH v2] perf sort: only insert overhead && overhead_children when no overhead* field given
From: Du, Changbin
Date: Tue Jul 04 2017 - 23:08:03 EST
On Thu, Jun 29, 2017 at 05:22:52PM +0200, Jiri Olsa wrote:
> > > --- a/tools/perf/util/sort.c
> > > +++ b/tools/perf/util/sort.c
> > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > > if (sort__mode == SORT_MODE__DIFF)
> > > return keys;
> > >
> > > + if (strstr(keys, "overhead"))
> > > + return keys;
> > > +
> ah ok, I think it's right.. basically you're forcing
> precedence of the -s option over the --children option
> you could have your example working by running:
> $ perf report -s overhead,sym --no-children
Thanks for the knowledge.
> please state something like:
> * User already stated overhead within -s option,
> * do not mangle with that.
I'll add this as comment around the change for v3.
Description: PGP signature