Re: [patches] Re: [PATCH 1/9] RISC-V: Init and Halt Code

From: Thomas Gleixner
Date: Wed Jul 05 2017 - 02:41:28 EST


On Tue, 4 Jul 2017, Karsten Merker wrote:
> On Tue, Jul 04, 2017 at 10:37:37PM +0200, Thomas Gleixner wrote:
> > > + timer_riscv_init(cpu_id, riscv_timebase, &rdtime, &next_event);
> >
> > This function is nowhere.... Neither can I find the header file.
>
> It is part of the RISC-V clock driver patchset, please cf.
> https://github.com/riscv/riscv-linux/commit/0705a31372d4714e54c5104e02021441785c1fd5
>
> https://github.com/riscv/riscv-linux/commits/riscv-for-submission-v4
> has the various RISC-V-related driver patchsets merged in (in
> addition to this arch patchset).

Well, then please move that timer stuff to the clock driver patchset, so
the combo can be reviewed. Having half functional patches with missing
references here and there makes review a PITA.

Thanks,

tglx