Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options
From: Steven Rostedt
Date: Wed Jul 05 2017 - 11:30:37 EST
On Wed, 05 Jul 2017 16:24:09 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:
> btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs
> calls replace_mount_options(), but they then implement their own
> ->show_options() methods and don't touch s_options, rendering the saved
> options unnecessary. I'm trying to eliminate s_options to make it easier
> to implement a context-based mount where the mount options can be passed
> individually over a file descriptor.
> Remove the calls to save/replace_mount_options() call in these cases.
As this is patch 1/14, is there any dependency on this working? That
is, it is safe to simply remove this caller from those locations? Or
are there dependencies on having any of the 2-14 patches added to make
it not cause issues?