Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options

From: Greg Kroah-Hartman
Date: Wed Jul 05 2017 - 14:50:42 EST

On Wed, Jul 05, 2017 at 04:24:09PM +0100, David Howells wrote:
> btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs
> calls replace_mount_options(), but they then implement their own
> ->show_options() methods and don't touch s_options, rendering the saved
> options unnecessary. I'm trying to eliminate s_options to make it easier
> to implement a context-based mount where the mount options can be passed
> individually over a file descriptor.
> Remove the calls to save/replace_mount_options() call in these cases.
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Chris Mason <clm@xxxxxx>
> cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> cc: linux-btrfs@xxxxxxxxxxxxxxx
> cc: reiserfs-devel@xxxxxxxxxxxxxxx

For debugfs:
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>