Re: [PATCH v2] alarmtimer: Fix unavailable wake-up source in sysfs
From: John Stultz
Date: Wed Jul 05 2017 - 15:45:50 EST
On Wed, Jul 5, 2017 at 5:08 AM, Geert Uytterhoeven
> Currently the alarmtimer registers a wake-up source unconditionally,
> regardless of the system having a (wake-up capable) RTC or not.
> Hence the alarmtimer will always show up in
> /sys/kernel/debug/wakeup_sources, even if it is not available, and thus
> cannot be a wake-up source.
> To fix this, postpone registration until a wake-up capable RTC device is
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> - Move ws inside #ifdef CONFIG_RTC_CLASS to avoid a defined but not
> used warning if CONFIG_RTC_CLASS is disabled,
> - Reword.
This looks ok to me. I've queued it up for testing, targeting 4.14.
Let me know if its more urgent.