Re: [PATCH v9 0/3] Tango PCIe controller support
Date: Wed Jul 05 2017 - 16:39:53 EST
On 05/07/2017 20:03, Bjorn Helgaas wrote:
> On Wed, Jul 05, 2017 at 12:55:37AM +0200, Mason wrote:
>> On 04/07/2017 22:24, Bjorn Helgaas wrote:
>>> I made the trivial changes I mentioned, added a dependency on
>>> CONFIG_BROKEN (for the config/MMIO muxing issue), and put these on
>>> pci/host-tango. I can't build or test this, so I probably broke
>>> something in the process. I think the combination of the boot-time
>>> warning, the taint, and CONFIG_BROKEN is a reasonable amount of
>>> warning that a user should expect issues.
>>> Can you take a look and see if it works for you?
>> Thanks. I'll take it for a spin ASAP.
>> TAINT_CRAP... Smirk. I didn't see that one in the docs:
>> Oh wait... TAINT_CRAP is "C" => a staging driver has been loaded
> I wish it had a less pejorative, more descriptive name. But it seems like
> the closest to this situation.
Maybe it is not too late to submit a patch to Linus
Here are a few candidates, off the top of my head:
>> The one issue I anticipate with "depends on BROKEN" is
>> when I add support for revision 2, which isn't broken.
> How about this:
> - Rename PCIE_TANGO to PCIE_TANGO_REV1
> - PCIE_TANGO_REV1 depends on BROKEN
> - Add rev2 support later, enabled by PCIE_TANGO
> - PCIE_TANGO_REV1 depends on PCIE_TANGO && BROKEN
> I updated pci/host-tango along these lines (without rev2 support,
And support for REV1 wouldn't be compiled in, unless
BROKEN is selected? Yes, I think that could fly.
Don't you think the naming should follow the DT
convention of using the first SoC embedding the
IP (for the compatible string) ?
PCIE_TANGO_REV1 vs PCIE_TANGO_SMP8759
> I forgot to ask for a MAINTAINERS update. Can you send that, too,
There's a "catch-all" rule for everything tango-related:
M: Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx>
Is that enough?
> Which reminds me -- are these two addreses
> Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx>
> Mason <slash.tmp@xxxxxxx>
> different names for the same person? Conversations are easier for me
> if I can keep who's who straight :)
Well, there are many voices inside my head, but yes,
respectively professional and personal addresses.