Re: [PATCH] rtc: brcmstb-waketimer: fix settime function
From: Florian Fainelli
Date: Wed Jul 05 2017 - 17:53:05 EST
On 07/05/2017 02:13 PM, Alexandre Belloni wrote:
> On 28/06/2017 at 22:07:34 +0200, Arnd Bergmann wrote:
>> gcc warns about an unused variable in the new driver:
>> drivers/rtc/rtc-brcmstb-waketimer.c: In function 'brcmstb_waketmr_settime':
>> drivers/rtc/rtc-brcmstb-waketimer.c:142:6: error: unused variable 'ret' [-Werror=unused-variable]
>> The same function also doesn't handle overflow correctly, this makes
>> it return -EINVAL when passed a time that doesn't fit within the
>> range of the register.
>> Fixes: 9f4ad359c801 ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> drivers/rtc/rtc-brcmstb-waketimer.c | 19 ++++++++++++-------
>> 1 file changed, 12 insertions(+), 7 deletions(-)
> I've squashed it in the original commit, I hope this is fine for you.
Works for me, thanks Alexandre!