Re: [GIT PULL] Btrfs for 4.13

From: Christoph Hellwig
Date: Wed Jul 05 2017 - 21:51:21 EST

On Wed, Jul 05, 2017 at 04:45:49PM -0700, Linus Torvalds wrote:
> Ouch, yeah, that was annoying. And yes, I ended up with several
> whitespace differences but other than that it looks the same. Oh well.
> Jens, Christoph, let's not do that stupid thing with status-vs-error
> ever again, ok?

It should be done now :)

Back to serious - this work had to be done as we could not communicate
errors properly in the block layer with people inventing their own
codes all the time. That being said, in retrospective I should have
tried a gradual approach that first defines the new code to the old
errors and left the fields in place. I opted for the hard break to
make sure we can catch matching conversions by the compiler as very
few people run sparse for the __bitwise annotations, and some of
the drivers create so many sparse warnings that they would be lost

But I've learned and will try to make something like this gradual
if it comes up, and hope we won't have to do something like it again
at all.