Re: [PATCH v9 0/3] Tango PCIe controller support
Date: Thu Jul 06 2017 - 08:27:29 EST
On 06/07/2017 05:39, Bjorn Helgaas wrote:
> On Wed, Jul 05, 2017 at 11:59:33PM +0200, Mason wrote:
>> There were a few nits I wanted to address:
>> - Since we added suppress_bind_attrs = true, probe()
>> can only be called at init, so I wanted to mark __init
>> all the probe functions, to save space.
>> - I left the definition of MSI_MAX in the wrong patch
>> - You put a pointer to the pdev in the struct tango_pcie.
>> I think this is redundant, since the pdev already has a
>> pointer to the struct, as drvdata.
>> So I wanted to change tango_msi_probe() to take a pdev
>> as argument (to make it more like an actual probe function)
>> and derive pcie from pdev, instead of the other way around.
> I don't think tango_msi_probe() is really a "probe" function. It's
> all part of the tango driver, and it's not claiming a separate piece
> of hardware.
I agree that tango_msi_probe() is not a probe function;
it is merely a piece of the actual probe function (static
with single call site). I split the probe function in two,
because it seemed to make sense at the time.
Perhaps it's better to inline tango_msi_probe? That would
avoid the issues of that function's name and parameters.
If you think it's better to keep the two pieces separate,
I can rename the MSI part to tango_msi_init() or some such.
But I'd like to avoid adding unnecessary fields to the struct.
> So I would keep the name and structure similar to these:
> BTW, those functions use irq_domain_add_linear(), while you are one of
> the very few callers of irq_domain_create_linear(). Why the difference?
> If your code does basically the same thing, it's very helpful to me if
> it *looks* basically the same.
It was a suggestion from Marc Z on 2017-03-23.
+ irq_dom = irq_domain_add_linear(NULL, MSI_COUNT, &msi_domain_ops, pcie);
Use irq_domain_create_linear, pass the same fwnode.
It seems odd to pass NULL as the first argument.
(As I had first done, when copying the Altera driver.)
>> Can I send you a patch series with these changes on Friday?
> I was planning to ask Linus to pull my branch tomorrow or Friday
> because I'm going on vacation next week and I don't want to leave
> right after he pulls it. So the sooner the better.
I'm not at the office today, but I'll do it first thing
tomorrow. If it works out, great. If I'm too late, well
there's 4.14 to look forward to.