RE: [PATCH v2 0/9] Remove spin_unlock_wait()
From: David Laight
Date: Thu Jul 06 2017 - 10:12:37 EST
From: Paul E. McKenney
> Sent: 06 July 2017 00:30
> There is no agreed-upon definition of spin_unlock_wait()'s semantics,
> and it appears that all callers could do just as well with a lock/unlock
> pair. This series therefore removes spin_unlock_wait() and changes
> its users to instead use a lock/unlock pair. The commits are as follows,
> in three groups:
> 1-7. Change uses of spin_unlock_wait() and raw_spin_unlock_wait()
> to instead use a spin_lock/spin_unlock pair. These may be
> applied in any order, but must be applied before any later
> commits in this series. The commit logs state why I believe
> that these commits won't noticeably degrade performance.
I can't help feeling that it might be better to have a spin_lock_sync()
call that is equivalent to a spin_lock/spin_unlock pair.
The default implementation being an inline function that does exactly that.
This would let an architecture implement a more efficient version.
It might even be that this is the defined semantics of spin_unlock_wait().
Note that it can only be useful to do a spin_lock/unlock pair if it is
impossible for another code path to try to acquire the lock.
(Or, at least, the code can't care if the lock is acquired just after.)
So if it can de determined that the lock isn't held (a READ_ONCE()
might be enough) the lock itself need not be acquired (with the
associated slow bus cycles).