Re: [PATCH 12/18] drivers: s390: Move static and inline before return type
From: Julian Wiedmann
Date: Thu Jul 06 2017 - 14:04:44 EST
On 07/06/2017 02:25 PM, Heiko Carstens wrote:
> On Thu, Jul 06, 2017 at 03:57:19AM -0700, Joe Perches wrote:
>> On Thu, 2017-07-06 at 12:29 +0200, Heiko Carstens wrote:
>>> On Wed, Jul 05, 2017 at 01:02:21PM -0700, Joe Perches wrote:
>>>> Make the code like the rest of the kernel.
>>>> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.cqq
>>>> @@ -2408,7 +2408,7 @@ static int qeth_l3_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
>>>> return rc;
>>>> -int inline qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
>>>> +inline int qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
>>> Actually the function could be made static, and "inline" should be removed,
>>> considering the large function body.
>> I agree to a certain extent.
>> It's only used once and it looks like Klaus-Dieter Wacker
>> just missed adding static to this function.
>> $ git log --stat -p -1 ce73e10ee0cb6
>> commit ce73e10ee0cb6cde1c5075a2803da0f0eb5b2324
>> Author: Klaus-Dieter Wacker <kdwacker@xxxxxxxxxx>
>> But it also looks like inline is too often used in several
>> drivers/s390/net/*.c files, where most of those static inline
>> functions are only used once.
>> $ git grep -w inline drivers/s390/net/*.c | wc -l
>> Maybe inline removals should be a separate pass for all those.
> Yes, Ursula or Julian can address this if they care.
true, no shortage of inline in s390/net. I'll see about spending a few
OCD cycles on it...