Re: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return

From: Theodore Ts'o
Date: Thu Jul 06 2017 - 15:28:37 EST


On Fri, Jun 23, 2017 at 03:58:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The error return ret is not set on a successful return path and
> so it returns a garbage value. Ensure it is is set to zero on
> a successful return.
>
> Detected by CoverityScan, CID#1446616 ("Uninitialized scalar variable")
>
> Fixes: 3499c0fb822d ("quota: add get_inode_usage callback to transfer multi-inode charges")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks, I've folded this into the "quota: add get_inode_usage callback
to transfer multi-inode charges" with credit for your providing the
fix.

- Ted