Re: [linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver

From: icenowy
Date: Thu Jul 06 2017 - 19:21:40 EST

å 2017-07-07 04:46ïMaxime Ripard åéï

On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote:
The PH16 pin has a function with mux id 0x5, which is the DET pin of the
"sim" (smart card reader) IP block.

This function is missing both in the old A10 and A20 drivers, so it's
not found during the merge of these two drivers.

Add it to the driver. As we now merged A20 pinctrl driver to the A10
one, we need to only fix the A10 driver now.

Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>

I'm not sure what you mean there. It's not mentionned in the A10
datasheet, and neither in the A20. Where did you get that info from?

It's mentioned in all newest datasheets: "A10 Datasheet V1.70.pdf" and
"A20 Datasheet V1.41 20131230.pdf".


Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering