Re: [PATCH 14/15] kernel: convert futex_pi_state.refcount from atomic_t to refcount_t
Date: Fri Jul 07 2017 - 09:23:05 EST
On Fri, Jul 07, 2017 at 12:35:16PM +0200, Ingo Molnar wrote:
> * Reshetova, Elena <elena.reshetova@xxxxxxxxx> wrote:
> > > On Fri, 7 Jul 2017, Peter Zijlstra wrote:
> > >
> > > > On Fri, Jul 07, 2017 at 12:04:28PM +0300, Elena Reshetova wrote:
> > > > > refcount_t type and corresponding API should be
> > > > > used instead of atomic_t when the variable is used as
> > > > > a reference counter. This allows to avoid accidental
> > > > > refcounter overflows that might lead to use-after-free
> > > > > situations.
> > > > >
> > > > > Signed-off-by: Elena Reshetova <elena.reshetova@xxxxxxxxx>
> > > > > Signed-off-by: Hans Liljestrand <ishkamiel@xxxxxxxxx>
> > > > > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > > > > Signed-off-by: David Windsor <dwindsor@xxxxxxxxx>
> > > >
> > > > I'll let tglx comment on the SoB chain, I know he likes those :-) You
> > > > did Cc him right, seeing how he's the maintainer of this stuff..
> > >
> > > Right, that SOB chain is crap. It suggests that the patch was written by
> > > Elena and then carried on by Hans, handed over to Kees and from there to
> > > David. And now it's resent by Elena. Circular dependencies or what?
> > I will fix SOB on all patches and resend.
> Please don't resend any of these until the merge window is over! This is probably
> the worst possible moment to seek review feedback and merging...
Ah, you need a "I'm ignoring your patches for two weeks" email bot,
feel free to steal the text of mine below :)
This is the friendly semi-automated patch-bot of Greg Kroah-Hartman.
You have sent him a patch that has triggered this response.
Right now, the development tree you have sent a patch for is "closed"
due to the timing of the merge window. Don't worry, the patch(es) you
have sent are not lost, and will be looked at after the merge window is
over (after the -rc1 kernel is released by Linus).
So thank you for your patience and your patches will be reviewed at this
later time, you do not have to do anything further, this is just a short
note to let you know the patch status and so you don't worry they didn't
make it through.
greg k-h's patch email bot