Re: [PATCH] perf report: Fix broken arrow at row 0 in annotate view

From: Arnaldo Carvalho de Melo
Date: Fri Jul 07 2017 - 10:21:51 EST


Em Thu, Jun 08, 2017 at 02:01:44PM +0800, Jin Yao escreveu:
> When the jump instruction is displayed at the row 0 in annotate view,
> the arrow is broken. An example:
>
> 16.86 â âââje 82
> 0.01 â movsd (%rsp),%xmm0
> â movsd 0x8(%rsp),%xmm4
> â movsd 0x8(%rsp),%xmm1
> â movsd (%rsp),%xmm3
> â divsd %xmm4,%xmm0
> â divsd %xmm3,%xmm1
> â movsd (%rsp),%xmm2
> â addsd %xmm1,%xmm0
> â addsd %xmm2,%xmm0
> â movsd %xmm0,(%rsp)
> â82: sub $0x1,%ebx
> 83.03 â â jne 38
> â add $0x10,%rsp
> â xor %eax,%eax
> â pop %rbx
> â â retq
>
> The patch increments the row number before checking with 0.

Thanks, tested and applied!

- Arnaldo