Re: [GIT PULL] MFD for v4.13
From: Lee Jones
Date: Fri Jul 07 2017 - 18:50:32 EST
On Fri, 07 Jul 2017, Linus Torvalds wrote:
> On Fri, Jul 7, 2017 at 2:50 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++
> So I've pulled everything but this, because honestly, that file looks
> like utter garbage.
> Why are there all those _hundreds_ of odd defines for
> when it looks like you could just do one single one:
> // The sequence is one-based because somebody doesn't
> // know that indices start at 0. Thus the "-2".
> #define MADERA_WSEQ_SEQUENCE(x) (0x3000 + (x)*2 - 2)
> and similar things go for for pretty much EVERY SINGLE LINE in that
> 8-thousand line piece of nasty horrible crud.
> Being auto-generated doesn't really make this kind of thing any
> better. In fact, it makes it worse, because those stupid hardcoded
> names are often *harder* to use, because you cannot use a variable to
> index into things (which you may often want).
> So we have eight thousand lines of garbage that is
> (a) probably closer to 200x too many lines
> (b) less flexible than doing it right
> Honestly, tell me why would I want to merge something monstrous like that?
I'm inclined to agree and had my reservations. However based on
a previous conversation , I was convinced that it's actually the
right thing to do.
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog