Re: [git pull] vfs.git part 1
From: Michael Ellerman
Date: Fri Jul 07 2017 - 18:50:44 EST
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:
> On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>> The copy_flock_fields() macro has the arguments in order <from, to>,
>> but all the users seem to do it the other way around.
> Looking more at it, I think I'd also like copy_flock_fields() to take
> pointer arguments, to match all the code around it (both
> copy_to/from_user and the memset calls.
> The actual order of arguments I suspect Michael's patch did better -
> make the copy_flock_fields() just match the order of memcpy() and
> copy_to/from_user(), both of which have <dest,src> order.
> So I think my preferred patch would be something like this, even if it
> is bigger than either.
> Comments? Michael, does this work for your case?
Yeah that works, as committed in your tree. Sorry for the slow reply,
our time zones don't line up all that well :)