Re: [PATCH] kernel: cpu: hotplug: constify attribute_group structures.

From: Sebastian Andrzej Siewior
Date: Mon Jul 10 2017 - 03:14:53 EST


On 2017-06-29 17:40:47 [+0530], Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 12582 15361 20 27963 6d3b kernel/cpu.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 12710 15265 20 27995 6d5b kernel/cpu.o

While there does not seem to be anything wrong with it, why did the file
grow after the patch was applied?

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

Sebastian