Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

From: RafaÅ MiÅecki
Date: Mon Jul 10 2017 - 05:48:14 EST


On 7 July 2017 at 16:09, Russell Joyce <russell.joyce@xxxxxxxxxx> wrote:
> Add three basic LED triggers to brcmfmac, based on those in mac80211: one
> for transmit, one for receive, and one for combined transmit/receive.
>
> Signed-off-by: Russell Joyce <russell.joyce@xxxxxxxxxx>

1) I think most of it should be some cfg80211 shareable code.
2) This "rxtx" while surely present in other places sounds like a
workaround for LED subsystem limitation. Maybe it's time to finally
rework LED triggers.