Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition

From: Aleksa Sarai
Date: Tue Jul 11 2017 - 10:45:58 EST


Sent: 11 July 2017 01:12
This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag
because it doesn't copy anything from/to userspace to access the
argument.

Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl")
...
-#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */
+#define TIOCGPTPEER _IO('T', 0x41) /* Safely open the slave */

This is a user API change. When was the ioctl added?

It was just pulled this merge window (4.13-rc1).

% git tag --contains 54ebbfb1603415d9953c150535850d30609ef077
%

--
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html