Re: [RFC v5 34/38] procfs: display the protection-key number associated with a vma

From: Dave Hansen
Date: Tue Jul 11 2017 - 14:14:27 EST


On 07/05/2017 02:22 PM, Ram Pai wrote:
> +#ifdef CONFIG_PPC64_MEMORY_PROTECTION_KEYS
> +void arch_show_smap(struct seq_file *m, struct vm_area_struct *vma)
> +{
> + seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma));
> +}
> +#endif /* CONFIG_PPC64_MEMORY_PROTECTION_KEYS */

This seems like kinda silly unnecessary duplication. Could we just put
this in the fs/proc/ code and #ifdef it on ARCH_HAS_PKEYS?