Re: [PATCH] slub: make sure struct kmem_cache_node is initialized before publication

From: Christopher Lameter
Date: Wed Jul 12 2017 - 15:58:19 EST


On Wed, 12 Jul 2017, Andrew Morton wrote:

> - free_kmem_cache_nodes() frees the cache node before nulling out a
> reference to it
>
> - init_kmem_cache_nodes() publishes the cache node before initializing it
>
> Neither of these matter at runtime because the cache nodes cannot be
> looked up by any other thread. But it's neater and more consistent to
> reorder these.

The compiler or processor may reorder them at will anyways. But if its
tidier....

Acked-by: Christoph Lameter <cl@xxxxxxxxx>