Re: [PATCH v2] xattr: Enable security.capability in user namespaces

From: Serge E. Hallyn
Date: Wed Jul 12 2017 - 21:01:50 EST


Quoting Eric W. Biederman (ebiederm@xxxxxxxxxxxx):
> James Morris <jmorris@xxxxxxxxx> writes:
>
> > On Wed, 12 Jul 2017, Serge E. Hallyn wrote:
> >
> >> Quoting Eric W. Biederman (ebiederm@xxxxxxxxxxxx):
> >> > Stefan Berger <"Stefan Bergerstefanb"@linux.vnet.ibm.com> writes:
> >> > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>
> >> > > Signed-off-by: Serge Hallyn <serge@xxxxxxxxxx>
> >> > > Reviewed-by: Serge Hallyn <serge@xxxxxxxxxx>
> >> >
> >> > It doesn't look like this is coming through Serge so I don't see how
> >> > the Signed-off-by tag is legtimate.
> >>
> >> This is mostly explained by the fact that there have been a *lot* of
> >> changes, many of them discussed in private emails.

I wasn't clear here. There were a lot of changes between the first
mention of the approach and the posting of v1.

My point was that I did in fact agree to Reviewed-by, and the fact that
I've found a few more things to point out only reflects my missing them
before. I don't think my name is being mis-used.

> > Please try and keep technical discussions public or at least document them
> > when reposting the patches.
>
> Yes please.
>
> A public discussion helps to understand what the challenges are.

Yes, all discussion (that I can find in my mbox) since v1 has been public.

-serge