Re: [PATCH 3/3] fat: fix quoted string splits

From: Joe Perches
Date: Sun Jul 16 2017 - 11:06:57 EST


On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Sat, 2017-07-15 at 04:20 +0300, Andy Shevchenko wrote:
> > > On Sat, Jul 15, 2017 at 2:05 AM, Carlos Palminha
> > > <CARLOS.PALMINHA@xxxxxxxxxxxx> wrote:
> > > > corrects quoted string split across lines, based on checkpatch.
> > >
> > > At some point you may switch
> > >
> > > fat_msg(sb, KERN_ERR, ...)
> > >
> > > to
> > >
> > > fat_fs_error(sb, ...)
> >
> > The output would be different.
>
> As much as it adds 'error, ' at the beginning of message. I can't
> consider this a bad idea.

Adding "error" to KERN_ERR output is unnecessary
and if really desired, should be done by dmesg
or equivalent.