Re: [PATCH] edac: constify attribute_group structures.

From: Borislav Petkov
Date: Mon Jul 17 2017 - 04:23:43 EST


On Mon, Jul 03, 2017 at 04:09:33PM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 6026 2541 12 8579 2183 drivers/edac/edac_mc_sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6090 2477 12 8579 2183 drivers/edac/edac_mc_sysfs.o

What is that before/after thing supposed to tell me exactly?

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---
> drivers/edac/edac_mc_sysfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Anyway, I've merged your two EDAC patches into one and applied it.

Thanks.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--