Re: [PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

From: Lee Jones
Date: Tue Jul 18 2017 - 03:14:27 EST


On Mon, 17 Jul 2017, Bastien Nocera wrote:

> On Mon, 2017-07-17 at 12:58 +0100, Lee Jones wrote:
> > The commit log should not be empty.
>
> Fair.
>
> > Please provide information as to why this change is required, etc.
>
> SSIA.

Disagree. The $SUBJECT says what your intention is, but does not
describe why it's required or what tangible difference it makes to a
running system.

> I also sent another patch to the same addresses labelled:
> [PATCH] gpio: crystalcove: Uniquify driver name

Okay? I did wonder why the GPIO list was Cc'ed on this patch.

In this case the Intel guys are not listed as Maintainers for these
files, so you'll have to run ./get_maintainer.pl and pick them from
the committers entries.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog