Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context

From: Alexey Budankov
Date: Tue Jul 18 2017 - 11:32:55 EST


On 18.07.2017 18:23, Alexander Shishkin wrote:
> Alexey Budankov <alexey.budankov@xxxxxxxxxxxxxxx> writes:
>
>>> You probably also want to explain this change, for example change the
>>> @group_list description, saying that something else links into it now.
>>>
>>
>> The whole patch as a single commit, attached to patch v5 4/4, may provide
>> the complete view of suggested changes.
>
> No, each patch has to be readable on its own. If one has to jump between
> patches to figure out what's going on, it's already discouraging. The
> point of submitting a patch, on the other hand, is to encourage the
> reviewers to read on.

Agree. That was my initial intention when splitting into several patches.

>
> Regards,
> --
> Alex
>