Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

From: Julia Lawall
Date: Sat Jul 22 2017 - 02:39:38 EST




On Sat, 22 Jul 2017, Borislav Petkov wrote:

> On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote:
> > Someone pointed out that the rule is probably not OK when the address of
> > the static variable is taken, because then it is likely being used as
> > permanent storage.
>
> Makes sense to me.
>
> > An improved rule is:
>
> Do you think it is worth having it in scripts/coccinelle/ ?

Sure. Now that it has been a bit more sanity checked.

> I don't think Gustavo would mind putting it there :)

OK, I will check with him.

julia

>
> Thanks.
>
> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.
> --
>