Re: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API

From: Christoph Hellwig
Date: Mon Jul 24 2017 - 11:54:25 EST


On Wed, Jul 19, 2017 at 09:28:55PM +0300, Andy Shevchenko wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.

Can you split the uapi changes into a separate patch?

I'd love to kill the guid_le userspace exposure, but I'd also like to
see how current userspace uses them. Obviously your change is not
a break in the ABI, but it is a break in the API. I would prefer if
we could not expose it, but I'd like to hear feedback from the consumers
of these UAPI headers - the fields aren't used in kernel space at all,
but userspace might be using it, and we'll need to look into alternatives
for it.