Re: [PATCH 1/2] printk: Make CONFIG_PRINTK_TIME an int

From: Luis R. Rodriguez
Date: Tue Jul 25 2017 - 08:55:49 EST


On Tue, Jul 25, 2017 at 08:17:26AM -0400, Prarit Bhargava wrote:
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index fc47863f629c..26cf6cadd267 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -1202,8 +1202,40 @@ static inline void boot_delay_msec(int level)
> }
> #endif
>
> -static bool printk_time = IS_ENABLED(CONFIG_PRINTK_TIME);
> -module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
> +static int printk_time = CONFIG_PRINTK_TIME;

You could just use unsigned int but is the reason you went with int to
enable backward compatibility with the old bool =y or =n?

Luis