Re: [patches] [PATCH 17/17] RISC-V: Build Infastructure

From: Arnd Bergmann
Date: Wed Jul 26 2017 - 02:52:19 EST


On Wed, Jul 26, 2017 at 7:20 AM, Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote:
> On Tue, 25 Jul 2017 19:57:17 PDT (-0700), j.neuschaefer@xxxxxxx wrote:
>> On Tue, Jul 11, 2017 at 06:31:30PM -0700, Palmer Dabbelt wrote:
>>> This patch contains all the build infastructure that actually enables
>>> the RISC-V port. This includes Makefiles, linker scripts, and Kconfig
>>> files. It also contains the only top-level change, which adds RISC-V to
>>> the list of architectures that need a sed run to produce the ARCH
>>> variable when building locally.
>>>
>>> Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx>
>>> ---
>> [...]
>>> +config ISA_C
>>> + bool "Emit compressed instructions when building Linux"
>>
>> As a user, I'd prefer to have slightly more globally-recognisable names
>> than ISA_<single letter> for RISC-V instruction set architecture
>> extensions. A quick "git grep -A2 'config ISA'" shows the following
>> Kconfig symbols:
>
> Good timing: I was about to submit a v6 patch set. I'm cool with
> CONFIG_ISA_RVC and friends, do you mind submitting a patch?

I'd generally prefix those highly architecture specific ones with the
architecture name, e.g. CONFIG_RISCV_ISA_C

Arnd