Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h

From: Arnaldo Carvalho de Melo
Date: Wed Jul 26 2017 - 13:57:56 EST


Em Wed, Jul 26, 2017 at 10:31:48AM -0700, Dan Williams escreveu:
> On Wed, Jul 26, 2017 at 10:19 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> > * Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> >> On Wed, Jul 26, 2017 at 4:29 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> > which I could initially mistake for a commit about scheduler completions ;-)
> >
> > Or:

> > 2ad6a39c9ae9: Fix attribute sizes to match NFIT 0.8s2
> > cc7cb44385d3: Import initial infrastructure

> > etc.

> > I suppose all that could be corrected, SOBs added, titles clarified and prefixed
> > with tools/ndctl, but then it wouldn't really be unmodified history anymore,
> > right?

> > At that point we might as well do a clean start - and not import ~500 extra
> > commits into the kernel tree?

> I think keeping the history is worth it, similar reasoning to why we
> kept the btrfs history. Also, since the history is linear and already
> rewritten by 'git filter-branch' to move everything to tools/ndctl/ it
> wouldn't be that much more work to go clean up these few commits that
> are problematic.

Hey, but we can have something like:

https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/

It goes all the way to the 0.12 kernel.

If someone wants to go that far, just clone that tree, merge it, etc.

Could that be the solution for this case as well?

I.e. the kernel history prior to what we have in linux.git can be
accessed via that other tree, history.git, can we have ndctl-history.git
and linux.git + ndctl from now on?

If you prefer to go full merge, then I think prefixing + SOB'ing should
be done, right?

- Arnaldo